Bitcoin Core GUI staging repository https://github.com/bitcoin/bitcoin
  • C++ 64.7%
  • Python 18.9%
  • C 12.7%
  • CMake 1.2%
  • Shell 0.9%
  • Other 1.3%
Find a file
Repository files (latest commit first)
Filename Latest commit message Latest commit date
Ava Chow 7bff765d51
Merge bitcoin/bitcoin#35639: external_signer: validate fingerprint from enumerate response
4c9de7d5b3 external_signer: validate fingerprint from enumerate response (Kyle 🐆)

Pull request description:

  `enumeratesigners` takes the `fingerprint` field from the external signer's `enumerate` output and stores it without checking it. That value is later handed back to the signer command as `--fingerprint <value>` (e.g. in `displayaddress`), so a malformed value propagates unchecked.

  A master key fingerprint is 4 bytes, i.e. 8 hex characters. This adds a check that the reported fingerprint is exactly 8 hex characters and throws a clear error otherwise. A functional test covers empty, wrong-length, and non-hex inputs.

ACKs for top commit:
  Sjors:
    utACK 4c9de7d5b3
  achow101:
    ACK 4c9de7d5b3
  sedited:
    ACK 4c9de7d5b3

Tree-SHA512: 7c3303b24e234e13a4c20c0b93552145b9ccffc29d1bae42ce8a2faf548377f051e52f8ffb3924679065b27d15fc7bf3859e5ae32a2bb185738cc29bc0ade486
2026-07-14 14:15:39 -07:00
.github ci: add netBSD cross CI job 2026-07-09 09:14:16 +01:00
.tx Update Transifex slug for 31.x 2026-02-06 13:40:59 +00:00
ci ci: use Ubuntu 26.04 for lint container 2026-07-14 11:22:48 +01:00
cmake Squashed 'src/ipc/libmultiprocess/' changes from 3edbe8f67c1..16bf05dea02 2026-07-05 16:57:57 -04:00
contrib chainparams: delete my DNS seed 2026-07-09 14:05:28 -04:00
depends Merge bitcoin/bitcoin#35427: depends: Build qt and qrencode packages on OpenBSD 2026-07-14 10:31:45 +01:00
doc Squashed 'src/ipc/libmultiprocess/' changes from 28e056576a..e8de5c7b68 2026-07-14 12:35:53 +02:00
share scripted-diff: [doc] Unify stale copyright headers 2025-12-16 22:21:15 +01:00
src Merge bitcoin/bitcoin#35639: external_signer: validate fingerprint from enumerate response 2026-07-14 14:15:39 -07:00
test Merge bitcoin/bitcoin#35639: external_signer: validate fingerprint from enumerate response 2026-07-14 14:15:39 -07:00
.editorconfig doc: remove reference to cirrus 2026-05-29 08:59:43 +01:00
.gitattributes cmake: Skip using git when building from source tarball or as subproject 2026-05-14 13:32:27 +01:00
.gitignore iwyu: Add patch to prefer angled brackets over quotes for includes 2025-12-17 20:28:42 +00:00
.python-version Don't pin Python patch version 2026-04-29 21:50:13 +01:00
.style.yapf Update .style.yapf 2023-06-01 23:35:10 +05:30
CMakeLists.txt Squashed 'src/ipc/libmultiprocess/' changes from 3edbe8f67c1..16bf05dea02 2026-07-05 16:57:57 -04:00
CMakePresets.json build: Bump VS minimum supported version to 18.3 2026-02-10 23:30:23 +00:00
CONTRIBUTING.md doc: add an AI contribution policy 2026-07-02 23:54:43 +01:00
COPYING doc: update copyright year 2025-12-29 17:50:43 +00:00
CTestConfig.cmake cmake: Set CTEST_NIGHTLY_START_TIME for CDash Nightly pipelines 2026-05-08 11:09:06 +02:00
INSTALL.md lint: Check for missing trailing newline 2025-05-13 15:50:02 +02:00
libbitcoinkernel.pc.in kernel: create monolithic kernel static library 2025-07-28 10:37:42 +01:00
README.md doc: fix transifex 404s 2025-06-19 11:22:14 +01:00
ruff.toml refactor: Use ignore-list over verbose select-list 2026-05-13 12:24:09 +02:00
SECURITY.md Remove myself as security contact 2026-07-09 16:44:50 -04:00
vcpkg.json vcpkg: remove libevent 2026-06-23 09:25:49 +01:00

Bitcoin Core integration/staging tree

https://bitcoincore.org

For an immediately usable, binary version of the Bitcoin Core software, see https://bitcoincore.org/en/download/.

What is Bitcoin Core?

Bitcoin Core connects to the Bitcoin peer-to-peer network to download and fully validate blocks and transactions. It also includes a wallet and graphical user interface, which can be optionally built.

Further information about Bitcoin Core is available in the doc folder.

License

Bitcoin Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/license/MIT.

Development Process

The master branch is regularly built (see doc/build-*.md for instructions) and tested, but it is not guaranteed to be completely stable. Tags are created regularly from release branches to indicate new official, stable release versions of Bitcoin Core.

The https://github.com/bitcoin-core/gui repository is used exclusively for the development of the GUI. Its master branch is identical in all monotree repositories. Release branches and tags do not exist, so please do not fork that repository unless it is for development reasons.

The contribution workflow is described in CONTRIBUTING.md and useful hints for developers can be found in doc/developer-notes.md.

Testing

Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.

Automated Testing

Developers are strongly encouraged to write unit tests for new code, and to submit new unit tests for old code. Unit tests can be compiled and run (assuming they weren't disabled during the generation of the build system) with: ctest. Further details on running and extending unit tests can be found in /src/test/README.md.

There are also regression and integration tests, written in Python. These tests can be run (if the test dependencies are installed) with: build/test/functional/test_runner.py (assuming build is your build directory).

The CI (Continuous Integration) systems make sure that every pull request is tested on Windows, Linux, and macOS. The CI must pass on all commits before merge to avoid unrelated CI failures on new pull requests.

Manual Quality Assurance (QA) Testing

Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.

Translations

Changes to translations as well as new translations can be submitted to Bitcoin Core's Transifex page.

Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.

Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.